Skip to content

refactor: rename input_* to data_* in _parse_fastcall_args#149

Merged
ifduyue merged 1 commit intomasterfrom
duyue/input->data
Apr 28, 2026
Merged

refactor: rename input_* to data_* in _parse_fastcall_args#149
ifduyue merged 1 commit intomasterfrom
duyue/input->data

Conversation

@ifduyue
Copy link
Copy Markdown
Owner

@ifduyue ifduyue commented Apr 28, 2026

Rename internal input_* variables to data_* in _parse_fastcall_args to align C internals with public Python API. Pure rename, no behavior change.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented Apr 28, 2026

Merging this PR will not alter performance

✅ 30 untouched benchmarks
⏩ 90 skipped benchmarks1


Comparing duyue/input->data (77574f3) with master (ff51b84)

Open in CodSpeed

Footnotes

  1. 90 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ifduyue ifduyue merged commit 7ddc056 into master Apr 28, 2026
25 of 45 checks passed
@ifduyue ifduyue deleted the duyue/input->data branch April 28, 2026 06:25
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the _parse_fastcall_args function in src/_xxhash.c by renaming the input_required and input_found variables to data_required and data_found to better align with the 'data' argument name. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant